-
Notifications
You must be signed in to change notification settings - Fork 3.3k
fix: move from getos to systeminformation to fix OS distro/release info #32283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+60
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
Aug 21, 2025
} | ||
|
||
return os.release() | ||
}).catch(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely could be a finally
but not worth the effort to test
cypress
|
Project |
cypress
|
Branch Review |
fix-os-info-release
|
Run status |
|
Run duration | 20m 14s |
Commit |
|
Committer | Jennifer Shehane |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
12
|
|
1102
|
|
0
|
|
26561
|
View all changes introduced in this branch ↗︎ |
UI Coverage
44.99%
|
|
---|---|
|
187
|
|
157
|
Accessibility
97.71%
|
|
---|---|
|
4 critical
8 serious
2 moderate
2 minor
|
|
110
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
results.osVersion
contains only Linux distribution without release version #30533Additional details
We were not getting the correct release for some distros and releases. We were using
getos
which is an npm package that hasn't been updated in 3 years.The format returned should be
os.platform os.distro - os.release
, but was often only getting values that often returned:os.platform -
os.platform - os.release
This PR further centralizes our use of the
systeminformation
package to get OS information.Steps to test
cypress
directorynode module-api.js
and see what osVersion is printedHow has the user experience changed?
Before
Cloud run
Local Module API
After
Cloud run
Local Module API
PR Tasks
cypress-documentation
?type definitions
?