chore: Update Chrome (stable) to 137.0.7151.55 #31794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jennifer-shehane
approved these changes
May 28, 2025
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
update-chrome-stable-from-136.0.7103.113-beta-from-137.0.7151.40
|
| Run status |
|
| Run duration | 18m 29s |
| Commit |
|
| Committer | Bill Glesias |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
816
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
63.64%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
56
|
Accessibility
96.27%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
142
|
AtofStryker
previously requested changes
May 28, 2025
AtofStryker
force-pushed
the
update-chrome-stable-from-136.0.7103.113-beta-from-137.0.7151.40
branch
7 times, most recently
from
0726534 to
c5795b7
Compare
…st extension loading in chrome
AtofStryker
force-pushed
the
update-chrome-stable-from-136.0.7103.113-beta-from-137.0.7151.40
branch
from
c5795b7 to
a4375e7
Compare
|
@jennifer-shehane this should now be ready for review |
mschile
reviewed
May 28, 2025
| @@ -865,7 +865,11 @@ const systemTests = { | |||
| const { browser } = options | |||
|
|
|||
| if (browser && !customBrowserPath) { | |||
| expect(String(browser).toLowerCase()).to.eq(browserName.toLowerCase()) | |||
| if (browser === 'chrome-for-testing') { | |||
| expect(String(browser).toLowerCase()).to.eq(browserName.toLowerCase().replaceAll(' ', '-')) | |||
There was a problem hiding this comment.
Why do we need to replace the spaces?
There was a problem hiding this comment.
its checking for chrome for testing because the logic just takes the browser name and makes it lower case, when I have it named chrome-for-testing. Felt better to have the hyphens as the name as its consistent with our current naming
mschile
reviewed
May 28, 2025
mschile
reviewed
May 28, 2025
mschile
reviewed
May 28, 2025
Co-authored-by: Matt Schile <mschile@cypress.io>
mschile
approved these changes
May 28, 2025
AtofStryker
deleted the
update-chrome-stable-from-136.0.7103.113-beta-from-137.0.7151.40
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was auto-generated to update the version(s) of Chrome for driver tests