Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: corrects unit calculations in the slow network error message during Test Replay uploads #31160

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

cacieprins
Copy link
Contributor

Additional details

Steps to test

How has the user experience changed?

PR Tasks

Copy link

cypress bot commented Feb 24, 2025

cypress    Run #60592

Run Properties:  status check passed Passed #60592  •  git commit 38bcd97a3b: Merge branch 'develop' into cacie/fix/slow-connection-error-msg
Project cypress
Branch Review cacie/fix/slow-connection-error-msg
Run status status check passed Passed #60592
Run duration 11m 02s
Commit git commit 38bcd97a3b: Merge branch 'develop' into cacie/fix/slow-connection-error-msg
Committer Cacie Prins
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 668
View all changes introduced in this branch ↗︎
UI Coverage  38.89%
  Untested elements 121  
  Tested elements 77  
Accessibility  92.05%
  Failed rules  3 critical   7 serious   1 moderate   1 minor
  Failed elements 526  

@cacieprins cacieprins marked this pull request as ready for review February 24, 2025 18:31
@jennifer-shehane jennifer-shehane merged commit 2d80905 into develop Feb 25, 2025
91 checks passed
@jennifer-shehane jennifer-shehane deleted the cacie/fix/slow-connection-error-msg branch February 25, 2025 14:41
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 25, 2025

Released in 14.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v14.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message for Test Replay upload failures caused by a slow connection is incorrect
3 participants