-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enable requiring cy.origin dependencies with require() and import() #24294
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Variables must either be defined within the ${cmd('origin')} command or passed in using the args option.`, | ||
Variables must either be defined within the ${cmd('origin')} command or passed in using the args option. | ||
|
||
Using \`require()\` or \`import()\` to include dependencies requires using the latest version of \`@cypress/webpack-preprocessor\`.`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest specifying the required version of the webpack preprocessor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trouble is, I won't know what version that is until this is merged and it's actually released.
Also, when this was originally released, I could have guessed the version was going to be 5.13.0
and hard-coded that into the error message, but webpack-preprocessor@5.13.0 ended being broken. That required a 5.13.1
release, meaning the error message would have been misleading. I think recommending the latest version is the safest bet.
User facing changelog
cy.origin()
callback usingrequire()
and dynamicimport()
. RemovedCypress.require()
.Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?