Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new plugin events 'before:spec', 'after:spec', 'before:run', and 'after:run' #2331

Merged
merged 33 commits into from
Jan 23, 2019
Merged

Add new plugin events 'before:spec', 'after:spec', 'before:run', and 'after:run' #2331

merged 33 commits into from
Jan 23, 2019

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Aug 13, 2018 •
edited
Loading

@chrisbreiding
implement before:spec, after:spec, and after:run plugin events
fdb6d20
@chrisbreiding
ensure server events only executed if registered
bee55d4
@chrisbreiding
don’t execute plugin event if plugins process has been killed
b550ba4
@chrisbreiding
call default preprocessor directly instead of registering it as plugin
daa001c 
makes things more consistent because now plugins are only registered by the user. this was an exception where we registered it as a plugin, but it’s unnecessary because we can just call it directly
@chrisbreiding
fix unit tests
3c99444
@chrisbreiding chrisbreiding self-assigned this Aug 13, 2018
@chrisbreiding chrisbreiding changed the title Add new plugin events 'before:spec', 'after:spec', and 'after:run' Add new plugin events 'before:spec', 'after:spec', 'before:run', and 'after:run' Aug 31, 2018
@chrisbreiding chrisbreiding mentioned this pull request Aug 31, 2018
Closed
@chrisbreiding chrisbreiding modified the milestone: Sprint 0.5 Sep 4, 2018
@chrisbreiding chrisbreiding mentioned this pull request Nov 26, 2018
Closed
31 tasks
@chrisbreiding chrisbreiding changed the base branch from develop to v4.0 December 13, 2018 20:44
@chrisbreiding chrisbreiding merged commit ac9340d into v4.0 Jan 23, 2019
@chrisbreiding chrisbreiding deleted the issue-2286-new-plugin-events branch January 23, 2019 15:17
@amitzur
Copy link

amitzur commented Jun 24, 2020

Hey 👋
Is this feature fixed already in some released version of Cypress?

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jun 24, 2020 •
edited
Loading

No, this was not released. There's a new issue to track this work here #6665

@denis-domanskii denis-domanskii mentioned this pull request Nov 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chrisbreiding chrisbreiding

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrisbreiding @amitzur @jennifer-shehane @brian-mann