Skip to content

fix: call screencastOpts as a function for starting a screencast on electron. #23001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2022
Merged

fix: call screencastOpts as a function for starting a screencast on electron. #23001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d24bb17
fix: call screencastOpts as a function for starting a screencast on e…
mjhenkes Jul 28, 2022
11058d3
Update packages/server/lib/modes/record.js
mjhenkes Jul 28, 2022
68bb26a
Merge branch 'develop' into matth/fix/issue-17627-hang-fix
mjhenkes Jul 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/server/lib/browsers/electron.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const _getAutomation = async function (win, options, parent) {
// workaround: start and stop screencasts between screenshots
// @see https://github.com/cypress-io/cypress/pull/6555#issuecomment-596747134
if (!options.onScreencastFrame) {
await sendCommand('Page.startScreencast', screencastOpts)
await sendCommand('Page.startScreencast', screencastOpts())
const ret = await fn(message, data)

await sendCommand('Page.stopScreencast')
Expand Down Expand Up @@ -117,7 +117,7 @@ const _maybeRecordVideo = async function (webContents, options) {
}
})

await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts)
await webContents.debugger.sendCommand('Page.startScreencast', screencastOpts())
}

module.exports = {
Expand Down
2 changes: 2 additions & 0 deletions packages/server/lib/modes/record.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,6 +784,8 @@ const createRunAndRecordSpecs = (options = {}) => {
})

if (response === responseDidFail) {
debug('`responseDidFail` equals `response`, allowing browser to hang until it is killed: Response %o', { responseDidFail })
Copy link
Member

@emilyrohrbough emilyrohrbough Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just kill the process?

Copy link
Contributor Author

@mjhenkes mjhenkes Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the safest (easiest) option. I don't have context for why this was setup this way, but now we will have logs when/ if it happens.


// dont call the cb, let the browser hang until it's killed
return
}
Expand Down