Skip to content

Conversation

@ZachJW34
Copy link
Contributor

User facing changelog

na

Additional details

Pairing with @jordanpowell88 on Angular stuff and came across some slight improvements to the mount and dev-server. We now bind the mount response to the Cypress.log of the mount command, and we made a few build overrides based on the @angular/cli dev-server overrides.

Steps to test

You can test the mount by running yarn workspace @cypress/webpack-dev-server and clicking on the angular.cy.ts test. Make sure to run yarn to build everything first.

How has the user experience changed?

Video shows the output of clicking on the mount command in the command log and the network requests shows the removal of the bundle hashing e.g. spec-0.abfj8083urn.js -> spec-0.js

Screen.Recording.2022-07-27.at.10.54.19.AM.mov

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@ZachJW34 ZachJW34 requested a review from a team as a code owner July 27, 2022 15:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 27, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Jul 28, 2022



Test summary

4934 0 63 0Flakiness 1


Run details

Project cypress
Status Passed
Commit d79426f
Started Jul 28, 2022 2:47 PM
Ended Jul 28, 2022 3:01 PM
Duration 14:03 💡
OS Linux Debian - 11.3
Browser Firefox 99

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/e2e/origin/commands/assertions.cy.ts Flakiness
1 cy.origin assertions > #consoleProps > .should() and .and()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 merged commit aedb1e9 into develop Jul 28, 2022
@ZachJW34 ZachJW34 deleted the zachw/angular-tweaks branch July 28, 2022 15:23
@ZachJW34 ZachJW34 mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants