-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cypress/schematic): run configuration does not work anymore without baseUrl #21629
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
npm/cypress-schematic/src/builders/cypress/cypressBuilderOptions.ts
Outdated
Show resolved
Hide resolved
8199bfc
to
36fd1a4
Compare
…ct if not set by default
@ZachJW34 what do we typically do when the Percy tests fail? Nothing I touched should have altered those in any way. |
@admah Your changes have no impact on UI so we can ignore the Percy diffs. I reran the build that flaked, so let's get this merged once everything (besides Percy) is green |
Fixes #21555.
Users can now add custom options to
devServerTarget
inangular.json
to specifybaseUrl
: