-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: head content reset, fix #19721 #21291
fix: head content reset, fix #19721 #21291
Conversation
Thanks for taking the time to open a PR!
|
@Akryum Thanks for the contribution! Can you rebase your branch so as to only include the vue change? Might be easier to checkout latest master and copy your changes over. |
ffbe9b9
to
7fb9ef9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you. This was missed when we changed how we clean up the document.
CI is not working correctly for external contributors. I believe it is fixed on develop so I've created a PR getting master up to date. Once we get that merged we can get a new build for this PR |
@ZachJW34 I see there are some (probably flacky) errors for this run: https://circleci.com/gh/cypress-io/cypress/1499006?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
@Akryum going to merge, the flake you are seeing is due to a bug with how we run our tests and you being an external contributor. |
User facing changelog
Fixed Vue component style missing after the first test.
Additional details
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?