Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: head content reset, fix #19721 #21291

Merged
merged 2 commits into from
May 3, 2022

Conversation

Akryum
Copy link
Contributor

@Akryum Akryum commented May 2, 2022

User facing changelog

Fixed Vue component style missing after the first test.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@Akryum Akryum requested a review from a team as a code owner May 2, 2022 13:49
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 2, 2022

Thanks for taking the time to open a PR!

@JessicaSachs JessicaSachs changed the base branch from develop to master May 2, 2022 19:48
@JessicaSachs JessicaSachs requested a review from a team as a code owner May 2, 2022 19:48
@JessicaSachs JessicaSachs requested review from jennifer-shehane and removed request for a team May 2, 2022 19:48
@ZachJW34
Copy link
Contributor

ZachJW34 commented May 2, 2022

@Akryum Thanks for the contribution! Can you rebase your branch so as to only include the vue change? Might be easier to checkout latest master and copy your changes over.

@JessicaSachs JessicaSachs changed the base branch from master to develop May 2, 2022 20:29
@Akryum Akryum force-pushed the issue-19721-missing-vue-style branch from ffbe9b9 to 7fb9ef9 Compare May 2, 2022 20:30
@Akryum Akryum changed the base branch from develop to master May 2, 2022 20:31
Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@JessicaSachs JessicaSachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. This was missed when we changed how we clean up the document.

@ZachJW34
Copy link
Contributor

ZachJW34 commented May 2, 2022

CI is not working correctly for external contributors. I believe it is fixed on develop so I've created a PR getting master up to date. Once we get that merged we can get a new build for this PR

@Akryum
Copy link
Contributor Author

Akryum commented May 3, 2022

@ZachJW34
Copy link
Contributor

ZachJW34 commented May 3, 2022

@Akryum going to merge, the flake you are seeing is due to a bug with how we run our tests and you being an external contributor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@cypress/vue - Global component does only include CSS in first test
3 participants