fix(unify): Do not crash when an ill formed URL request is proxied

[ryanthemanuel]

• Closes SIGSEGV with ERR_TLS_REQUIRED_SERVER_NAME in Server.addContext #9220

User facing changelog

The Cypress App will no longer crash when proxying an ill formed request. For example, if the application under test has a resource of "http: //localhost/asset.js" (notice the extraneous space) the Cypress App will no longer crash. Instead, a debug message will be logged and the asset will fail to load.

Additional details

The goal here is to treat these ill-formed requests just like any other requests that are problematic (e.g. not found resources). Thus, we don't attempt to stop the tests outright, but instead just fail the individual request.

How has the user experience changed?

Before:

Terminal:

After:

Terminal:

Browser Console:

Network:

PR Tasks

• Have tests been added/updated?
• [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

18146 • 1 • 202 • 0 • 3

---

Run details

Project	cypress
Status	Failed
Commit	1051fcd
Started	Dec 6, 2021 5:52 PM
Ended	Dec 6, 2021 6:04 PM
Duration	11:35 💡
OS	Linux Debian - 10.10
Browser	Multiple

View run in Cypress Dashboard ➡️

---

Failures

	cypress/integration/commands/net_stubbing_spec.ts		1
1	network stubbing > intercepting request > should delay the same amount on every response

---

Flakiness

	commands/net_stubbing_spec.ts		2
1	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
2	network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
	cypress/proxy-logging-spec.ts		1
1	... > works with forceNetworkError

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[flotwig]

This fix is good, but could you also add some error handling around the addContext call itself? It shouldn't crash the process if it fails. In fact, I don't really see why the promise chain isn't catching the error, is it an unhandled rejection or is there no .on('error' handler on the HTTPS server so this error crashes the process?

[ryanthemanuel]

@flotwig I have made the requested changes

[flotwig]

👍 Very nice 👍