feat(unify): add number of matches to specs search #19076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
lmiller1990
approved these changes
Nov 24, 2021
tgriesser
added a commit
that referenced
this pull request
Nov 29, 2021
* 10.0-release: refactor: remove @packages/desktop-gui (#19127) feat: switch browser runner (#19048) fix: bump resource class for tests that require node_modules install (#19079) fix(unify): reporter styles (#19034) fix test feat(unify): add number of matches to specs search (#19076) feat(launchpad): open in IDE modal and feature (#18975) fix: 10.0 appveyor updateyaml (#19074)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
The Specs List page now shows the number of matches for the current search in the search bar.
Additional details
This PR does a couple of other small things:
politein the specs page, but also in InlineSpecsListHeader.vue, where it isn't present visibly in the design, but it is still useful to announce to assistive technology that the result set is updated.placeholderattribute in InlineSpecsListHeader.vue has been replaced with a genuine label element, and a new ticket created to do this more generally with our core Input component.input[type=search]has been hidden as it clashed with the location of the matches count info. I do think the "clear search" function is useful, but it probably needs some input from design in order to look right, and can be implemented with a custom icon.How has the user experience changed?
Newly added results counter:
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?