Skip to content

fix: flaky redirect test #19042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 23, 2021
Merged

fix: flaky redirect test #19042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
20f7167
'Fix' flaky redirect test
mjhenkes Nov 22, 2021
c33d617
Merge branch 'develop' into fix-flaky-redirect-test
mjhenkes Nov 22, 2021
30eb630
Merge branch 'develop' into fix-flaky-redirect-test
mjhenkes Nov 22, 2021
2749017
Merge branch 'develop' into fix-flaky-redirect-test
mjhenkes Nov 22, 2021
f0fa47c
Merge branch 'develop' into fix-flaky-redirect-test
mjhenkes Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/driver/cypress/fixtures/meta-redirect-timeout.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<!DOCTYPE html>
<head>
<meta http-equiv="refresh" content="0; url=/timeout?ms=100" />
<meta http-equiv="refresh" content="0; url=/redirect-timeout" />
<title>Page Redirect</title>
</head>
<body>
Expand Down
8 changes: 8 additions & 0 deletions packages/driver/cypress/plugins/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,14 @@ const createApp = (port) => {
})
})

app.get('/redirect-timeout', (req, res) => {
return Promise
.delay(100)
.then(() => {
return res.send('<html><body>timeout</body></html>')
})
})

Comment on lines +46 to +53
Copy link
Contributor

@flotwig flotwig Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is there something blocking you from creating a cy.intercept() instead of a new route in server.js? This file be balloonin'. I guess you'd have to update the test to deal with the add'l logs.

Copy link
Contributor Author

@mjhenkes mjhenkes Nov 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this was my attempt to be minimally invasive.

app.get('/custom-headers', (req, res) => {
return res.set('x-foo', 'bar')
.send('<html><body>hello there</body></html>')
Expand Down