Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore within subject when screenshotting the entire runner #14264

Merged
merged 2 commits into from
Dec 28, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Dec 21, 2020

User facing changelog

The combination of cy.within(() => cy.screenshot(name, {capture: 'runner'}) no longer captures the element and instead captures the test runner as expected.

Additional details

We avoid surprising behavior

How has the user experience changed?

Instead of the within element, we get the test runner screenshot

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 21, 2020



Test summary

3955 0 52 1


Run details

Project cypress
Status Passed
Commit 70e4fbd
Started Dec 23, 2020 5:01 AM
Ended Dec 23, 2020 5:12 AM
Duration 10:39 💡
OS Linux Debian - 10.5
Browser Firefox 77

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@bahmutov
Copy link
Contributor Author

unrelated failed test

@bahmutov bahmutov merged commit 590dfa4 into develop Dec 28, 2020
@emilyrohrbough emilyrohrbough deleted the screenshot-issue-14253 branch August 1, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cy.within followed by cy.screenshot capture runner does not capture runner
2 participants