Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow fixtures folder to be the same as integration folder #14234

Merged
merged 5 commits into from
Dec 21, 2020

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Dec 18, 2020

User facing changelog

Cypress no longer fails to find specs if you set the fixtures folder to be the same as the integration folder. Example

{
  "fixturesFolder": "cypress/integration"
}

Additional details

I think this is a valid use case - keeping fixtures right next to the specs, especially if the specs themselves are organized in subfolders as in https://glebbahmutov.com/blog/split-spec/

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 18, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Dec 18, 2020



Test summary

9162 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit 0a09a74
Started Dec 18, 2020 5:44 PM
Ended Dec 18, 2020 5:57 PM
Duration 12:55 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@bahmutov bahmutov marked this pull request as ready for review December 18, 2020 19:28
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yah, I agree, this is a valid use case. Looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypress doesnt support having the same folder for fixtures and integration
2 participants