Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create fall-through for API warning messaging #4489

Closed
jennifer-shehane opened this issue Jun 18, 2019 · 2 comments · Fixed by #4567
Closed

Create fall-through for API warning messaging #4489

jennifer-shehane opened this issue Jun 18, 2019 · 2 comments · Fixed by #4567
Assignees
Labels
pkg/server This is due to an issue in the packages/server directory type: error message

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Jun 18, 2019

Current behavior:

If the API sends a warning message to the Test Runner that is not recognized as a key, the warning message is never displayed.

There is also some new messaging that should be added per our upcoming Dashboard changes:

  • FREE_PLAN_NEARING_MONTHLY_TESTS
  • PAID_PLAN_NEARING_MONTHLY_TESTS
  • PAID_PLAN_PARALLELIZATION_DISABLED
  • PAID_PLAN_RUNS_HIDDEN
  • PLAN_IN_GRACE_PERIOD_PARALLEL_FEATURE_USED (somehow there is not a message written for this, although this is an older message)

Desired behavior:

If the Cypress API sends a warning message and we haven't coded a key to match it, it should fall-through and print the API's message as is.

Steps to reproduce: (app code and test code)

Versions

Cypress 3.3.1

@jennifer-shehane jennifer-shehane added pkg/server This is due to an issue in the packages/server directory stage: ready for work The issue is reproducible and in scope type: error message labels Jun 18, 2019
@jennifer-shehane jennifer-shehane self-assigned this Jun 18, 2019
@chrisbreiding chrisbreiding self-assigned this Jun 18, 2019
@cypress-bot cypress-bot bot added stage: work in progress and removed stage: ready for work The issue is reproducible and in scope labels Jun 18, 2019
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: work in progress labels Jun 26, 2019
@brian-mann brian-mann changed the title Create fall-through for API warning messaging + new warning messaging for usage limits Create fall-through for API warning messaging Jun 27, 2019
@brian-mann
Copy link
Member

Closed by #4567

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 27, 2019

Released in 3.3.2.

@cypress-bot cypress-bot bot removed the stage: needs review The PR code is done & tested, needs review label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/server This is due to an issue in the packages/server directory type: error message
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants