-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Open
Labels
process: contributingRelated to contributing to the Cypress codebaseRelated to contributing to the Cypress codebasetype: choreWork is required w/ no deliverable to end userWork is required w/ no deliverable to end user
Description
What would you like?
The documentation section CONTRIBUTING > Docker as a performance constrained environment should provide instructions which work.
Why is this needed?
In the section CONTRIBUTING > Docker as a performance constrained environment:
-
The docker compose run option
--service-port
is incorrect and provokes the error messageunknown flag: --service-port
. The correct option is--service-ports
. This is already correctly and indirectly implemented through the scriptdocker-dev
(which invokes "./scripts/run-docker-local.sh dev"). -
The use of the Cypress Docker container
cypress/browsers:latest
by thedev
service in docker-compose.yml is not fully compatible with the instructions to build Cypress withyarn install
.- As mentioned in CONTRIBUTING > Requirements > Debian/Ubuntu,
g++
andmake
are needed to build Cypress without errors. - Cypress should be built using the version of Node.js in .node-version, which is currently
18.17.1
22.15.1
.cypress/browsers:latest
however currently runs under Node.js20.17.0
22.18.0
LTS, which is the wrong version.
- As mentioned in CONTRIBUTING > Requirements > Debian/Ubuntu,
Other
No response
Metadata
Metadata
Assignees
Labels
process: contributingRelated to contributing to the Cypress codebaseRelated to contributing to the Cypress codebasetype: choreWork is required w/ no deliverable to end userWork is required w/ no deliverable to end user