reduce flake in log updates

Author: emilyrohrbough

packages/driver/cypress/integration/commands/sessions/sessions.spec.js

@@ -111,6 +111,7 @@ describe('cy.session', { retries: 0 }, () => {
         setupTestContext()
         cy.log('create new session to test against')
         cy.session('session-1', setup)
+        .wait(4) // ensure last log clear page has been updated
       })
 
       it('successfully creates new session', () => {
@@ -194,6 +195,7 @@ describe('cy.session', { retries: 0 }, () => {
         cy.log('create new session with validation to test against')
 
         cy.session('session-1', setup, { validate })
+        .wait(4) // ensure last log clear page has been updated
       })
 
       it('successfully creates new session and validates it', () => {
@@ -273,12 +275,16 @@ describe('cy.session', { retries: 0 }, () => {
         setupTestContext()
         cy.log('create new session with validation to test against')
 
-        cy.on('fail', (err) => {
-          expect(setup).to.be.calledOnce
-          expect(validate).to.be.calledOnce
-          expect(clearPageCount, 'total times session cleared the page').to.eq(2)
-          expect(err.message).to.contain('Your `cy.session` **validate** callback returned false')
-          done()
+        cy.once('fail', (err) => {
+          new Promise((resolve) => {
+            setTimeout(() => {
+              expect(setup).to.be.calledOnce
+              expect(validate).to.be.calledOnce
+              expect(clearPageCount, 'total times session cleared the page').to.eq(2)
+              expect(err.message).to.contain('Your `cy.session` **validate** callback returned false')
+              done()
+            }, 4)
+          })
         })
 
         validate.callsFake(() => false)
@@ -350,6 +356,7 @@ describe('cy.session', { retries: 0 }, () => {
 
         cy.log('restore session to test against')
         cy.session('session-1', setup)
+        .wait(4) // ensure last log clear page has been updated
       })
 
       it('successfully restores saved session', () => {
@@ -407,6 +414,7 @@ describe('cy.session', { retries: 0 }, () => {
 
         cy.log('restore session to test against')
         cy.session('session-1', setup, { validate })
+        .wait(4) // ensure last log clear page has been updated
       })
 
       it('successfully restores saved session', () => {
@@ -481,6 +489,7 @@ describe('cy.session', { retries: 0 }, () => {
 
         cy.log('restore session to test against')
         cy.session('session-1', setup, { validate })
+        .wait(4) // ensure last log clear page has been updated
       })
 
       it('successfully recreates session', () => {
@@ -596,11 +605,13 @@ describe('cy.session', { retries: 0 }, () => {
         })
 
         cy.once('fail', (err) => {
-          expect(err.message).to.contain('Your `cy.session` **validate** callback returned false')
-          expect(setup).to.be.calledOnce
-          expect(validate).to.be.calledTwice
-          expect(clearPageCount, 'total times session cleared the page').to.eq(3)
-          done()
+          return setTimeout(() => {
+            expect(err.message).to.contain('Your `cy.session` **validate** callback returned false')
+            expect(setup).to.be.calledOnce
+            expect(validate).to.be.calledTwice
+            expect(clearPageCount, 'total times session cleared the page').to.eq(3)
+            done()
+          }, 4)// ensure last log clear page has been updated
         })
 
         cy.log('restore session to test against')