Skip to content

Commit f8e818e

Browse files
fix test failures observed in run mode
1 parent e657dea commit f8e818e

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

packages/driver/cypress/integration/commands/sessions/sessions.spec.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,11 @@ describe('cy.session', { retries: 0 }, () => {
265265
})
266266

267267
describe('create session with failed validation flow', () => {
268-
before(function (done) {
268+
// TODO: make this a before hook. Before hook is timing out under the hood
269+
// and the failure is being captured in tests further down in run-mode.
270+
// This is only visible in open-mode when setting a breakpoint in
271+
// patchRunnableResetTimeout in src/cypress/mocha.ts
272+
it('fails validation', function (done) {
269273
setupTestContext()
270274
cy.log('create new session with validation to test against')
271275

@@ -577,7 +581,11 @@ describe('cy.session', { retries: 0 }, () => {
577581
})
578582

579583
describe('recreates existing session with failed validation flow', () => {
580-
before(function (done) {
584+
// TODO: make this a before hook. Before hook is timing out under the hood
585+
// and the failure is being captured in tests further down in run-mode.
586+
// This is only visible in open-mode when setting a breakpoint in
587+
// patchRunnableResetTimeout in src/cypress/mocha.ts
588+
it('fails to recreate session', function (done) {
581589
setupTestContext()
582590
cy.log('create new session for test')
583591
cy.session('session-1', setup, { validate })

0 commit comments

Comments
 (0)