Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit playwright-webkit version 1.34 pinning #5884

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

MikeMcC399
Copy link
Contributor

Issue

The WebKit (Experimental) section specifies

Install the playwright-webkit npm package in your repo to acquire WebKit itself: npm install playwright-webkit@1.34 --save-dev

playwright@1.34.3 was released more than one year ago in May 2023.

Change

In the WebKit (Experimental) section, remove the playwright-webkit@1.34 version pinning and format the command so it is copyable.

Move the Playwright acknowledgement out of the instructions to install.

Copy link

netlify bot commented Jul 31, 2024

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 57bb85c

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399

This comment was marked as outdated.

@MikeMcC399 MikeMcC399 marked this pull request as ready for review July 31, 2024 10:53
@jennifer-shehane jennifer-shehane self-requested a review July 31, 2024 17:26
@jennifer-shehane jennifer-shehane merged commit fb22e34 into cypress-io:main Jul 31, 2024
3 checks passed
@MikeMcC399 MikeMcC399 deleted the playwright-webkit-no-pin branch August 1, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants