Skip to content

Conversation

@AshwanthramKL
Copy link
Contributor

@netlify
Copy link

netlify bot commented Jun 2, 2023

👷 Deploy request for cypress-docs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 0b59908

@CLAassistant
Copy link

CLAassistant commented Jun 2, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@MikeMcC399
Copy link
Contributor

@AshwanthramKL

Will you sign the CLA as requested? If not, your PR cannot be processed.

@AshwanthramKL
Copy link
Contributor Author

@AshwanthramKL

Will you sign the CLA as requested? If not, your PR cannot be processed.

@MikeMcC399 I have signed it now. Please check.

@nagash77 nagash77 merged commit 1768423 into cypress-io:main Jun 5, 2023
@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Jun 5, 2023

@AshwanthramKL

Congratulations on getting your PR accepted!

If you were to write the following, then your PR would have been automatically linked and the issues would then have been automatically closed after the PR was closed:

(see Linking a pull request to an issue using a keyword)

You have to follow the syntax though. If you write "fixes issue #5131" for instance (with the word "issue" between) then it does not link the PR to the issue automatically.

If no moderator steps in, perhaps you could write a note into those two issues that they should be closed now? Edit: now closed. No further action needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants