Skip to content

Update webinars.yml #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2019
Merged

Update webinars.yml #2007

merged 3 commits into from
Aug 14, 2019

Conversation

mguery
Copy link

@mguery mguery commented Aug 13, 2019

Adding links from Youtube to the webinars page

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Media that is hosted on youtube does not require a url, but only the youtubeId - the embedded video is generated automatically from that ID.

There is an issue however, highlighted by gleb in this issue, with the main links not reflecting this autogenerated youtube link. Instead of adding the full links, I'll update the template to autogenerate these links correctly. #1998

… to autogenerate the urls when youtube id is provided.
@jennifer-shehane jennifer-shehane merged commit 45f8753 into develop Aug 14, 2019
@matthamil matthamil deleted the mguery-webinar-links-81319 branch April 14, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants