-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Copy untranslated english pages to other languages #1961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy untranslated english pages to other languages #1961
Conversation
Test summaryRun details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Japanese docs did have the title translated, so this ends up blowing out the translated title - which is why this test is failing.
I've been going back and forth a bit on these titles. TBH, it's a duplicate that's uneccesary - the title is already defined in the relevant en.yml
, ja.yml
and is the title that should show at the top of the page.
On the other hand, I feel like removing the title from the meta-data makes it a little bit confusing about which file you're editing??? I don't know. We should probably just remove the title from the meta-data.
yeah, I don't think titles in each Markdown document matter - I usually know which document I am editing from the filename itself displayed on top of the document. I would not count just titles there as translations. Continuing with Chinese docs. |
I have removed the rest of the duplicates, and have updated the test to not look at the translated doc titles. |
Yeah, I am suggesting just removing the metadata at the top of the pages - and using the defined titles in the relevant en.yml, ja.yml doc, which are all translated. |
@jennifer-shehane I think removing the meta-data title on each page and fetching it from the |
I really wish I had been given time to review this before merging in. I tried writing some partial new info to a translated file (as is common), and am running into an issue with lint because the entire How does someone commit any translations to these actual translated docs if they are ignored? My use case is that I am adding some new wording to the |
Instead looks at the Git information to find English pages without corresponding checked in fully translated file, and copies the English file as a pre-build step (called from
index.js
that runs Hexo)