Add doc for window events #1512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbreiding
changed the base branch from
develop
to
issue-890-background-updates
| --- | ||
| title: window:<event> | ||
| --- | ||
|
|
There was a problem hiding this comment.
What if their page has several windows, like if they have iframes on the page, can they listen to the iframe's window events? Can we show an example of this if so?
There was a problem hiding this comment.
No, it's the status quo as far as iframe support is concerned. It only binds to the AUT's top window. We'll have to do extra work when we add iframe support, but it shouldn't change the API. The window is available as event.target, so the user can know which iframe window it is based on that.
jennifer-shehane
approved these changes
Mar 25, 2019
31 tasks
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Closes #1465