Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add doc page about retry-ability #1314

Merged
merged 17 commits into from
Feb 12, 2019
Merged

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Jan 17, 2019

done

items below will be done separately

I am thinking how to better address these, since they don't really fit into the example used through the page. It might take another separate PR

Code example in https://github.com/cypress-io/cypress-example-todomvc/tree/doc-retry-ability

@lukeapage
Copy link
Contributor

Would be worth mentioning cypress-pipe which allows you to write custom commands that have retry-ability?

@bahmutov bahmutov changed the title WIP: start doc page about retry-ability start doc page about retry-ability Feb 5, 2019
@bahmutov bahmutov changed the title start doc page about retry-ability add doc page about retry-ability Feb 5, 2019
@jennifer-shehane
Copy link
Member

You want this reviewed now? I see some checkboxes not done, so I'm unsure.

@bahmutov
Copy link
Contributor Author

bahmutov commented Feb 5, 2019

@jennifer-shehane I think the unchecked boxes should be addressed in separate PRs. For example, adding retry-ability to the custom commands should be documented in the custom commands guide. so I would like to land this so I can create a section in the testing workshop based on this doc.

bahmutov and others added 4 commits February 5, 2019 09:38
- Added ‘what you’ll learn’ section
- changed uses of the work ‘select’ to ‘query’ to avoid confusion
- properly formatted cy commands
- Fixed links that were not using url helper
- aligned code comments
- structured content into lists when possible
- fixed header hierarchy
- other minor content edits
@jennifer-shehane
Copy link
Member

@bahmutov
Copy link
Contributor Author

bahmutov commented Feb 7, 2019

oh no @jennifer-shehane

1) Guides Table of Contents displays toc:
     CypressError: cy.request() failed on:

http://localhost:2222/guides/core-concepts/retry-ability.html

The response we received from your web server was:

  > 404: Not Found

This was considered a failure because the status code was not '2xx' or '3xx'.

If you do not want status codes to cause failures pass the option: 'failOnStatusCode: false'

-----------------------------------------------------------

The request we sent was:

Method: GET
URL: http://localhost:2222/guides/core-concepts/retry-ability.html
Headers: {
  "user-agent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Cypress/3.1.5 Chrome/59.0.3071.115 Electron/1.8.2 Safari/537.36",
  "accept": "*/*",
  "accept-encoding": "gzip, deflate"
}

@jennifer-shehane
Copy link
Member

oh, duh, I forgot to move the actual file 🙄 Will fix now

@bahmutov
Copy link
Contributor Author

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cypress.on link was pushed

@jennifer-shehane jennifer-shehane merged commit fb579bf into develop Feb 12, 2019
@matthamil matthamil deleted the document-retry-ability-1278 branch April 14, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document retry-ability
3 participants