-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doc page about retry-ability #1314
Conversation
Would be worth mentioning cypress-pipe which allows you to write custom commands that have retry-ability? |
You want this reviewed now? I see some checkboxes not done, so I'm unsure. |
@jennifer-shehane I think the unchecked boxes should be addressed in separate PRs. For example, adding retry-ability to the custom commands should be documented in the custom commands guide. so I would like to land this so I can create a section in the testing workshop based on this doc. |
- Added ‘what you’ll learn’ section - changed uses of the work ‘select’ to ‘query’ to avoid confusion - properly formatted cy commands - Fixed links that were not using url helper - aligned code comments - structured content into lists when possible - fixed header hierarchy - other minor content edits
Dependent on this: https://github.com/cypress-io/cypress-monorepo/issues/221 |
oh no @jennifer-shehane
|
oh, duh, I forgot to move the actual file 🙄 Will fix now |
Relevant testing workshop section https://gitpitch.com/cypress-io/testing-workshop-cypress?p=slides/11-retry-ability |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cypress.on link was pushed
done
cypress-pipe
and retrying clicks from blog post https://www.cypress.io/blog/2019/01/22/when-can-the-test-click/items below will be done separately
I am thinking how to better address these, since they don't really fit into the example used through the page. It might take another separate PR
Code example in https://github.com/cypress-io/cypress-example-todomvc/tree/doc-retry-ability