-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update to Debian 12 (bookworm) #1057
Conversation
|
This comment was marked as resolved.
This comment was marked as resolved.
Tests exhibit flake test-image-medium-browsers-test-browsers-edge failed once with the following error. On re-run, it passed.
|
Should we proceed with this PR? Are there any other tests needed? |
@MikeMcC399 We're going to have @AtofStryker take a look if he has some time this iteration. |
Very good! I'm going to be pushing through a few clean-up PRs in the meantime. They should not affect the Debian 12 PR in content though. |
This comment was marked as outdated.
This comment was marked as outdated.
5ded7e9
to
58a5d31
Compare
|
This comment was marked as outdated.
This comment was marked as outdated.
What do you think about merging this PR? |
I should be able to give it a thorough review today. Sorry for the delay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gave the factory a build, along with all other images in the docker-compose
on my amd64 Ubuntu 22.04.4 machine and ran the included docker image in addition. Everything works as expected. Thank you @MikeMcC399
Updated: * Debian base image to debian:12-slim (codename bookworm) * git version to 2.39.2
Thanks for your tests and the merge! It was good to see that the merge into |
bullseye
to Debian 12bookworm
#937Issue
Cypress Docker Images are currently built based on
debian:bullseye-slim
(Debian 11) from https://hub.docker.com/_/debiancypress-docker-images/factory/.env
Lines 7 to 8 in b952572
bullseye
which is theoldstable
releasebookworm
is the currentstable
release and it was originally released almost one year ago on June 10th, 2023.The Cypress Docker images need to transition to using the Debian
stable
release 12 (bookworm
).Changes
In factory/.env:
FACTORY_VERSION
is updated to4.0.0
since it is a major change moving from Debian 11 (bullseye
) to Debian 12 (bookworm
).BASE_IMAGE
is updated todebian:12-slim
(long-term equivalent todebian:bookworm-slim
, current equivalent todebian:12.5-slim
)Edit: This update is already done.FACTORY_DEFAULT_NODE_VERSION
is updated to 20.13.1 LTS, released May 9, 20242.39.2
for Debian 12Verification
On Ubunu
22.04.4
LTS, Node.jsv20.13.1
LTSExecute:
cd factory docker compose build factory docker compose build
and confirm that all images are built without errors or warnings.
Continue with
and confirm that the image builds without errors or warnings and runs successfully.
References