test: remove duplicate checkout in Verify resource_class config works

[MikeMcC399]

Situation

• The job Verify resource_class config works in .circleci/test-deploy.yml executes the step "Checkout code" twice

Change

• In the job Verify resource_class config works in .circleci/test-deploy.yml job, remove the parameter:

  pre-steps:
  - checkout

Verification

View the log of the "Verify resource_class config works" job and confirm that "Checkout code" only appears once, not twice.

[cypress-app-bot]

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.

[AtofStryker]

is this because the checkout is in the job above it here?

[MikeMcC399]

@AtofStryker

is this because the checkout is in the job above it here?

No, that's not the case. Each of these jobs runs separately. You can check this out if you view the logs.

• I suspect that the error crept in when the submitter of feat: Enable configuring Docker resource_class for run job #512 copied, pasted and adapted the previous job in the workflow and took the checkout parameter as well.

[AtofStryker]

@MikeMcC399 OK I can see it in the master branch here. I'm not too familiar with the orb code so where is the other checkout coming from?

[MikeMcC399]

@AtofStryker

OK I can see it in the master branch here. I'm not too familiar with the orb code so where is the other checkout coming from?

I don't know if I'm really the right person to be explaining the Cypress orb. I'm continually working at the edge of my comfort zone! This is what I see, attempting to analyze the hierarchy of calls:

In the master branch, the job "Verify resource_class config works"

circleci-orb/.circleci/test-deploy.yml

Line 146 in e67d53f

- cypress/run:

uses the predefined Cypress orb job cypress/run which includes commands cypress/install and cypress/run-tests

The cypress/install command includes the step

circleci-orb/src/commands/install.yml

Lines 57 to 60 in e67d53f

	- unless:
	condition: << parameters.skip-checkout >>
	steps:
	- checkout

which includes the CircleCI checkout key.

[AtofStryker]

@AtofStryker

OK I can see it in the master branch here. I'm not too familiar with the orb code so where is the other checkout coming from?

I don't know if I'm really the right person to be explaining the Cypress orb. I'm continually working at the edge of my comfort zone! This is what I see, attempting to analyze the hierarchy of calls:

In the master branch, the job "Verify resource_class config works"

circleci-orb/.circleci/test-deploy.yml

Line 146 in e67d53f

- cypress/run:

uses the predefined Cypress orb job cypress/run which includes commands cypress/install and cypress/run-tests

The cypress/install command includes the step

circleci-orb/src/commands/install.yml

Lines 57 to 60 in e67d53f

	- unless:
	condition: << parameters.skip-checkout >>
	steps:
	- checkout

which includes the CircleCI checkout key.

@MikeMcC399 OK this makes sense now. Going to approve and merge this in. Thank you!