Skip to content

refactor(frontend): maintain a dedicated logout page to separate session termination from navigation handling, preventing related issues #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

refactor(frontend): maintain a dedicated logout page to separate session termination from navigation handling, preventing related issues #1750

wants to merge 4 commits into from

Conversation

@mercihabam
Copy link
Member

No description provided.

@mercihabam mercihabam requested a review from kroky October 17, 2025 13:07
@kroky
Copy link
Member

kroky commented Oct 17, 2025

Hey, isn't this a dupe of #1742 ?

@mercihabam
Copy link
Member Author

mercihabam commented Oct 17, 2025 •
edited
Loading

Hey, isn't this a dupe of #1742 ?

They intend to fix the same issue, but I just checked the current behavior in master, when the user session expires, a Server error message is shown instead of a login screen, which I think isn't better.

@kroky
Copy link
Member

kroky commented Oct 20, 2025

Ok, I have checked this deeper - can we do a more robust fix here? I suggest we use normal browser navigation for the logout action - it should be cleaning up any session, cookie, etc. data like normal logout procedure does and it doesn't make sense to be part of an inline JS navigation - e.g. we face the problem of other ajax calls failing but there can be more than that. I suggest we simply turn the logout functionality into a normal browser visit of the logout page.

mercihabam and others added 2 commits October 21, 2025 12:32
@mercihabam
Merge branch 'master' into fix-endless-reload
dad8c12
@mercihabam
WIP: create a separate logout page, clearing all logout made inline i…
13b974c 
…n js navigation

TODO:
- ensure that the navbar is updated to the latest markup, so that the logout link query is accurate
- remove previous logout functions
- implement, logout confirm action
- etc.
@mercihabam mercihabam marked this pull request as draft October 21, 2025 20:44
@mercihabam
Copy link
Member Author

@kroky, those changes involve quite a bit of refactoring. What do you say about keeping the minimal fix in 9f85c4c, which won't be definitive, and continuing with the changes you suggested once the next release is made and stabilized (something between 2.5.1...2.5.3)?

@kroky
Copy link
Member

kroky commented Oct 23, 2025

Yes, we don't want a full refactor now. Let's keep this for after the release.

@mercihabam
Copy link
Member Author

So, I opened: #1758.

@mercihabam mercihabam changed the title fix(frontend): prevent endless browser reload when user session is terminated refactor(frontend): maintain a dedicated logout page to separate session termination from navigation handling, preventing related issues Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kroky kroky Awaiting requested review from kroky

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mercihabam @kroky