feat: add cardano #970
Closed
feat: add cardano #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneurlax
reviewed
Aug 28, 2024
sneurlax
reviewed
Aug 28, 2024
Member
|
I just need to doublecheck tor support / usage, but otherwise this looks good to me. |
Contributor
Author
|
Tor support has been resolved by commit 1ec7ee95d268e5f9bff29d04a77fee5a0f9ebb72 @sneurlax @julian-CStack |
Member
Need to make sure that an HttpClient can resolve/supports .onion domains |
sneurlax
previously approved these changes
Sep 11, 2024
sneurlax
previously approved these changes
Sep 14, 2024
Member
sneurlax
left a comment
sneurlax
left a comment
There was a problem hiding this comment.
latest commit since last review is good
Member
|
Included in / superseded by #995 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.