-
Notifications
You must be signed in to change notification settings - Fork 96
Custom pin length #555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Custom pin length #555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## staging #555 +/- ##
=======================================
Coverage 9.38% 9.38%
=======================================
Files 635 635
Lines 69152 69161 +9
=======================================
+ Hits 6488 6489 +1
- Misses 62664 62672 +8
|
julian-CStack
approved these changes
May 26, 2023
julian-CStack
added a commit
that referenced
this pull request
May 26, 2023
* WIP: pinCount stuff * pin decoration + and pinCount is 0 * pin length tweaks * fixes error when backspacing pin + add icon to flushbar * removed Constants.pinLength + changes to "change pin" setting * testing pin output * WIP: tests pass + commented out isRandom pin 1234 * removed pin output --------- Co-authored-by: ryleedavis <rylee@cypherstack.com> Co-authored-by: julian <julian@cypherstack.com>
julian-CStack
added a commit
that referenced
this pull request
May 26, 2023
* WIP: pinCount stuff * pin decoration + and pinCount is 0 * pin length tweaks * fixes error when backspacing pin + add icon to flushbar * removed Constants.pinLength + changes to "change pin" setting * testing pin output * WIP: tests pass + commented out isRandom pin 1234 * removed pin output --------- Co-authored-by: ryleedavis <rylee@cypherstack.com> Co-authored-by: julian <julian@cypherstack.com>
julian-CStack
added a commit
to cypherstack/stack_duo
that referenced
this pull request
May 26, 2023
* WIP: pinCount stuff * pin decoration + and pinCount is 0 * pin length tweaks * fixes error when backspacing pin + add icon to flushbar * removed Constants.pinLength + changes to "change pin" setting * testing pin output * WIP: tests pass + commented out isRandom pin 1234 * removed pin output --------- Co-authored-by: ryleedavis <rylee@cypherstack.com> Co-authored-by: julian <julian@cypherstack.com>
julian-CStack
added a commit
to cypherstack/stack_duo
that referenced
this pull request
May 26, 2023
* WIP: pinCount stuff * pin decoration + and pinCount is 0 * pin length tweaks * fixes error when backspacing pin + add icon to flushbar * removed Constants.pinLength + changes to "change pin" setting * testing pin output * WIP: tests pass + commented out isRandom pin 1234 * removed pin output --------- Co-authored-by: ryleedavis <rylee@cypherstack.com> Co-authored-by: julian <julian@cypherstack.com>
julian-CStack
added a commit
to cypherstack/stack_duo
that referenced
this pull request
May 26, 2023
* WIP: pinCount stuff * pin decoration + and pinCount is 0 * pin length tweaks * fixes error when backspacing pin + add icon to flushbar * removed Constants.pinLength + changes to "change pin" setting * testing pin output * WIP: tests pass + commented out isRandom pin 1234 * removed pin output --------- Co-authored-by: ryleedavis <rylee@cypherstack.com> Co-authored-by: julian <julian@cypherstack.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.