Closed
Conversation
Collaborator
|
Hi, I think you should have a look at #66 |
Contributor
Author
yes, this was just a quick shot, if there is interest of reducing the dependency tree, I can do it on top of #66
First get rid of async => I think forcing consumer to pull/run an async mechinery/runtime while it's not strictly necessary is a pain. Especially if you want to bind to a language that does not have native support for async. Second: just keep a small dependency tree, I think it's always good on few aspects:
|
Collaborator
|
I think #74 solves this too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
just a POC that :
rayonreqwestbyminreq+urlnot tested btw, just to show a global approach