Skip to content

CM-35351 - Improve UX of violation cards #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024
Merged

CM-35351 - Improve UX of violation cards #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/panels/violation/card/iac.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export default `
</section>

<section class="hr details">
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
<div class="details-item">
<div class="details-item-title">In file:</div>
<div class="details-item-value file">None</div>
Expand All @@ -21,6 +17,10 @@ export default `
<div class="details-item-title">IaC Provider:</div>
<div class="details-item-value provider">None</div>
</div>
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
</section>

<section class="hr compact-first">
Expand Down
10 changes: 5 additions & 5 deletions src/panels/violation/card/sast.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export default `
</section>

<section class="hr details">
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
<div class="details-item">
<div class="details-item-title">In file:</div>
<div class="details-item-value file">None</div>
Expand All @@ -26,9 +22,13 @@ export default `
<div class="details-item-value language">None</div>
</div>
<div class="details-item">
<div class="details-item-title">SAST Engine:</div>
<div class="details-item-title">Security Tool:</div>
<div class="details-item-value engine">None</div>
</div>
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
</section>

<section class="hr compact-first">
Expand Down
10 changes: 5 additions & 5 deletions src/panels/violation/card/secret.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ export default `
</section>

<section class="hr details">
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
<div class="details-item">
<div class="details-item-title">In file:</div>
<div class="details-item-value file">None</div>
Expand All @@ -21,8 +17,12 @@ export default `
<div class="details-item-title">Secret SHA:</div>
<div class="details-item-value sha">None</div>
</div>
<div class="details-item">
<div class="details-item-title">Rule ID:</div>
<div class="details-item-value rule">None</div>
</div>
</section>

<section class="hr compact-first">
<div class="section-header">Summary</div>
<div class="summary-text">None</div>
Expand Down
1 change: 0 additions & 1 deletion src/services/scanners/IacScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ const detectionsToDiagnostics = async (
let message = `Severity: ${detection.severity}\n`;
message += `Description: ${detection.message}\n`;
message += `IaC Provider: ${detection.detection_details.infra_provider}\n`;
message += `Rule ID: ${detection.detection_rule_id}\n`;
message += `In file: ${detection.detection_details.file_name}\n`;

const diagnostic = new vscode.Diagnostic(
Expand Down
1 change: 0 additions & 1 deletion src/services/scanners/SastScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,6 @@ const detectionsToDiagnostics = async (

let message = `Severity: ${detection.severity}\n`;
message += `Description: ${detection.message}\n`;
message += `Rule ID: ${detection.detection_rule_id}\n`;
message += `In file: ${detection.detection_details.file_name}\n`;

const diagnostic = new vscode.Diagnostic(
Expand Down
1 change: 0 additions & 1 deletion src/services/scanners/ScaScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ const detectionsToDiagnostics = async (
if (detection_details.alert?.first_patched_version) {
message += `First patched version: ${detection_details.alert?.first_patched_version}\n`;
}
message += `Rule ID: ${detection.detection_rule_id}`;

if (isSupportedLockFile(file_name)) {
const packageFileName = getPackageFileForLockFile(path.basename(file_name));
Expand Down
1 change: 0 additions & 1 deletion src/services/scanners/SecretScanner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,6 @@ const detectionsToDiagnostics = async (
'within \'\' repository',
''
)}\n`;
message += `Rule ID: ${detection.detection_rule_id}\n`;
message += `In file: ${detection.detection_details.file_name}\n`;
message += `Secret SHA: ${detection.detection_details.sha512}`;

Expand Down