Skip to content

CM-30756 fixing route to scan-service and detectionsonline-service in order to skip check projects #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 1, 2024
Merged

CM-30756 fixing route to scan-service and detectionsonline-service in order to skip check projects #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
784c030
CM-30756 [cycode-cli] fixing route for scan-service and detectionsonl…
morsa4406 Jan 1, 2024
a72f8a7
CM-30756 [cycode-cli] fixing route for scan-service and detectionsonl…
morsa4406 Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions cycode/cyclient/scan_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ def __init__(
self.scan_cycode_client = scan_cycode_client
self.scan_config = scan_config

self.SCAN_CONTROLLER_PATH = 'api/v1/scan'
self.DETECTIONS_SERVICE_CONTROLLER_PATH = 'api/v1/detections'
self.SCAN_CONTROLLER_PATH = 'api/v1/cli-scan'
self.DETECTIONS_SERVICE_CONTROLLER_PATH = 'api/v1/detections/cli'
self.POLICIES_SERVICE_CONTROLLER_PATH_V3 = 'api/v3/policies'

self._hide_response_log = hide_response_log
Expand Down Expand Up @@ -151,7 +151,7 @@ def get_detection_rules(
return self._filter_detection_rules_by_ids(self.parse_detection_rules_response(response), detection_rules_ids)

def get_scan_detections_path(self) -> str:
return f'{self.scan_config.get_detections_prefix()}/{self.DETECTIONS_SERVICE_CONTROLLER_PATH}'
return f'{self.scan_config.get_detections_prefix()}/{self.DETECTIONS_SERVICE_CONTROLLER_PATH}/detections'

def get_scan_detections(self, scan_id: str) -> List[dict]:
params = {'scan_id': scan_id}
Expand Down