CM-25773 - Support TF Plan scans #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EfratIsrael
requested review from
MaorDavidzon,
MarshalX,
MichalBor and
artem-fedorov
as code owners
![cycode-security[bot]](https://avatars.githubusercontent.com/in/39308?s=60&v=4){kind=small}
|
@artem-fedorov @MichalBor @MarshalX @avishaiamiel please review |
MarshalX
reviewed
Aug 2, 2023
MarshalX
reviewed
Aug 2, 2023
|
@EfratIsrael pls re-request review when you will be ready |
doratias18
previously approved these changes
Aug 4, 2023
MarshalX
suggested changes
Aug 4, 2023
There was a problem hiding this comment.
good structure of test files! i like that!
btw do we expect that tf plans files could be in the directory with another IaC related files? "scan path" will scan everything related to IaC.
im asking because i wonder that our user-firendly exception doesn't show the path to invalid tf plan file. will it be a problem for the user to find it in the provided path with many subfolders?
MichalBor
previously approved these changes
Aug 6, 2023
doratias18
previously approved these changes
Aug 6, 2023
MarshalX
reviewed
Aug 7, 2023
cycode/cli/code_scanner.py
Outdated
| custom_exceptions.TfplanKeyError: CliError( | ||
| soft_fail=True, | ||
| code='key_error', | ||
| message=f'\n{e!s}' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.