Skip to content

Conversation

@PelegCycode
Copy link
Contributor

No description provided.

@PelegCycode PelegCycode requested a review from MarshalX as a code owner May 28, 2023 11:28
@PelegCycode PelegCycode self-assigned this May 28, 2023
@PelegCycode PelegCycode changed the title CM-23065 - skip on collect node_modules folder for sca npm CM-23040 - skip on collect node_modules folder for sca npm May 28, 2023
@MarshalX
Copy link
Contributor

@PelegCycode Could you please test your _is_file_relevant_for_sca_scan function directly by faking path strings using "os.path" module? I mean without creating files with some content like now

This is example how we can test path-related functions that will work on all operation system:
https://github.com/cycodehq-public/cycode-cli/blob/d071284556c2ae139480152e72884b1701c5f658/tests/test_zip_file.py#L16-L22

as you can see concat_unique_id works with strings too

@MarshalX
Copy link
Contributor

@PelegCycode the test looks great! Could you pls delete the prev one? and tests JS files that were commited

@MarshalX MarshalX changed the title CM-23040 - skip on collect node_modules folder for sca npm CM-23340 - Skip on collect node_modules folder for SCA npm May 29, 2023
@PelegCycode PelegCycode merged commit d105bf4 into main May 29, 2023
@PelegCycode PelegCycode deleted the CM-23340-SCA-CLI-scan-npm-path-should-skip-on-collect-node_modules-folder branch May 29, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants