-
Notifications
You must be signed in to change notification settings - Fork 55
CM-22829 - Migrate to Poetry; fix package structure; use dynamic versioning from Git Tags #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CM-22829 - Migrate to Poetry; fix package structure; use dynamic versioning from Git Tags #105
Conversation
2116df2 to
dda0b77
Compare
|
Some useful info to understand all things better Including config files to the package
It means our config.yml files are already included by default. I test it locally by run "poetry build" and unarchive the dist files. it works We should not use data_files anymore
We don't use setuptools anymore Poetry core fully covers our requirements. It automatically understand type of README, fetch the content from the file and so on Now we distribute 1 package inside of one PyPI project Previously our PyPi project contained 2 packages: cli, cyclient. This could lead to problems. Let's take a look at how our package is installed in the system (pip install cycode && pip uninstall cycode):
as we can see it creates 2 folders in the global system space for all Python packages. to be more specific to "site-packages" folder. And it's named "cli"
The name doesn't relate to cycode at all. Any other packages named "cli" will break something due to conflicts in the file system :( also, I want to mention, that if we want to provide a separate cyclient package we should distribute it separately on PyPi (in case we want to provide Open Source lib to communicate with our backend from a code. I mean without CLI) That's how the tree looks now after restructuring
But it breaks imports. @MichalBor let me know if some of our projects uses CLI by importing it directly in the code instead of interacting with command line interface Rework of versioning is coming soon. More details in the task |
|
@MarshalX I think the cycode runner use the cli as a package. |
👑 |
yeap. I checked it. but the version of the package is locked. Our update will not break it |








Uh oh!
There was an error while loading. Please reload this page.