Skip to content

Conversation

@MarshalX
Copy link
Contributor

@MarshalX MarshalX commented May 4, 2023

No description provided.

Copy link
Contributor

@MichalBor MichalBor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done!

@MarshalX MarshalX changed the title CM-22207 format auth command output to json CM-22207 - Format auth command output to json May 15, 2023
@MarshalX MarshalX changed the title CM-22207 - Format auth command output to json CM-22207 - Format auth command output to JSON May 15, 2023
# Conflicts:
#	cli/printers/__init__.py
#	cycode/cli/auth/auth_command.py
#	cycode/cli/code_scanner.py
#	cycode/cli/models.py
@MarshalX MarshalX requested a review from MaorDavidzon as a code owner May 18, 2023 09:22
@MarshalX
Copy link
Contributor Author

@MichalBor @artem-fedorov Take a look! Since I moved print_error and print_result to printers, I could not leave the code of printers without a little refactoring 😅

@MarshalX MarshalX requested a review from MichalBor May 18, 2023 14:14
Copy link
Contributor

@MichalBor MichalBor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!
next time please create separate PRs, it will be easier to review :)

@MarshalX MarshalX merged commit 5ca59e9 into main May 22, 2023
@MarshalX MarshalX deleted the CM-22207-format-auth-command-output-to-json branch May 22, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants