Skip to content

Fix server directory structure input #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

a3ng7n
Copy link

@a3ng7n a3ng7n commented Apr 18, 2025

(includes changes from #259 )

This makes clicking on a file in the directory structure insert the full file path to the include/exclude pattern. It does this by changing the output of _create_tree_structure from a single newline delimited string, to a list of those same lines, in tuples with the corresponding file path they represent.

The api interface that the user sees for ingest_query and format_node is kept the same; they both still output a tuple of three strings. But there's some added lifting to process_query to regenerate the context-aware directory tree, and use that within the html/js interaction functions. To eliminate this regeneration would mean either a very different architecture or changing the interfaces for ingest_query and format_node, both of which didn't seem like the right call.

keeping this as draft until if/when #259 gets merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant