Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not specify a release branch #15

Closed
tjoskar opened this issue Jan 17, 2020 · 3 comments · Fixed by #16
Closed

Can not specify a release branch #15

tjoskar opened this issue Jan 17, 2020 · 3 comments · Fixed by #16
Labels

Comments

@tjoskar
Copy link

tjoskar commented Jan 17, 2020

Describe the bug
It does not work to specify a release branch

Workflow

- name: 📦 Semantic Release
  uses: cycjimmy/semantic-release-action@v2
  id: semantic
  with:
    branch: develop
  env:
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

Expected behavior
I expect the release to be done on the develop branch but instead, I get this message:

This test run was triggered on the branch develop, while semantic-release is configured to only publish from master, therefore a new version won’t be published.

Additional context
If you take a look at the semantic API, you can see it accept branches but this code pass in branch:

branchOption.branch = branch;

I can create a PR if you want.

@cycjimmy
Copy link
Owner

I found that the JavaScript API of semantic-release@16 changed the property branch to branches.

I will fix this problem later, you can temporarily manually specify semantic-release@15 to use.

cycjimmy added a commit that referenced this issue Jan 19, 2020
parameter `branch` does not work in semantic v16(#15)

#15
github-actions bot pushed a commit that referenced this issue Jan 19, 2020
## [2.1.3](v2.1.2...v2.1.3) (2020-01-19)

### Bug Fixes

* **branch:** parameter `branch` does not work in semantic v16 ([3e27c51](3e27c51)), closes [#15](#15) [#15](#15)
@github-actions
Copy link

🎉 This issue has been resolved in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cycjimmy
Copy link
Owner

Thanks for your issue. It has been fixed in the latest version. @tjoskar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants