Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run applyModifiers() after remaking #20

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Run applyModifiers() after remaking #20

merged 1 commit into from
Jul 26, 2024

Conversation

Kyome22
Copy link
Collaborator

@Kyome22 Kyome22 commented Jul 24, 2024

Fixed a bug where WebView modifiers were not applied after executing remake().

@b1ackturtle
Copy link
Collaborator

@Kyome22
Oops, the UI test failed. Could you please fix it?
https://github.com/cybozu/WebUI/actions/runs/10107736246

@Kyome22
Copy link
Collaborator Author

Kyome22 commented Jul 26, 2024

@Kyome22 Oops, the UI test failed. Could you please fix it? https://github.com/cybozu/WebUI/actions/runs/10107736246

This is because GitHub Actions makes UI tests flaky.
It seems that it takes a long time to load the View, especially after executing WebViewProxy.clearAll().

@b1ackturtle
Copy link
Collaborator

This is because GitHub Actions makes UI tests flaky. It seems that it takes a long time to load the View, especially after executing WebViewProxy.clearAll().

Ah, I see. The flakiness is an issue, but it doesn't seem to be related to this PR. Thank you.

@b1ackturtle
Copy link
Collaborator

@Kyome22
Could you please squash the two commits into one?

@Kyome22
Copy link
Collaborator Author

Kyome22 commented Jul 26, 2024

@b1ackturtle

@Kyome22 Could you please squash the two commits into one?

DONE👌

@b1ackturtle b1ackturtle merged commit 3a61507 into main Jul 26, 2024
@b1ackturtle b1ackturtle deleted the fix-remakeable branch July 26, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants