Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #159

Merged
merged 6 commits into from
Apr 15, 2022
Merged

Update dependencies #159

merged 6 commits into from
Apr 15, 2022

Conversation

masa213f
Copy link
Contributor

@masa213f masa213f commented Apr 12, 2022 •
edited
Loading

  • Update dependencies: actions and go modules
  • Use gh command to create releases instead of actions/create-release.
  • Change some make targets to run go mod tidy in CI.

Signed-off-by: Masayuki Ishii masa213f@gmail.com

@masa213f masa213f self-assigned this Apr 12, 2022
@masa213f masa213f force-pushed the update-20220412 branch 3 times, most recently from 3b5bbfc to 7f9cad2 Compare April 12, 2022 08:35
@masa213f masa213f marked this pull request as ready for review April 12, 2022 08:41
@masa213f
Update actions
e6b7bdf 
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
@masa213f
Update makefile
5b6f7cf 
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
@masa213f
Update go modules
2d49227 
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
@masa213f masa213f changed the title Update actions Update dependencies Apr 14, 2022
@masa213f masa213f requested a review from yokaze April 14, 2022 08:01
@masa213f
fix
826fd1d
@masa213f
fix
e10e7bd 
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
yokaze
yokaze requested changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/release.yaml is still using Go 1.16. Can it be fixed?

@masa213f
fix
1ad518d 
Signed-off-by: Masayuki Ishii <masa213f@gmail.com>
@masa213f masa213f requested a review from yokaze April 15, 2022 02:16
yokaze
yokaze approved these changes Apr 15, 2022
View reviewed changes
Copy link
Contributor

@yokaze yokaze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit fcf61bd into main Apr 15, 2022
@masa213f masa213f deleted the update-20220412 branch April 15, 2022 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yokaze yokaze yokaze approved these changes

Assignees

@masa213f masa213f

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masa213f @yokaze