Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Internal Server Error when vm's power status cannot be confirmed #145

Merged
merged 5 commits into from
Apr 2, 2021

Conversation

ysksuzuki
Copy link
Contributor

@ysksuzuki ysksuzuki commented Apr 1, 2021

This PR fixes the internal server error that aborts node list command when vm's powers status cannot be confirmed. pmctl2 node list lists VM list without showing internal server error. pmctl2 node show shows power_Status: Unknown as follows.

$ pmctl2 node show boot-0 | jq .
{
  "name": "boot-0",
  "taps": {
    "r0-node1": "pm_tap04562b3f",
    "r0-node2": "pm_tap61b6b82f"
  },
  "volumes": [
    "root",
    "seed",
    "sabakan"
  ],
  "cpu": 8,
  "memory": "4G",
  "uefi": false,
  "tpm": false,
  "smbios": {
    "manufacturer": "",
    "product": "",
    "serial": "fb8f2417d0b4db30050719c31ce02a2e8141bbd8"
  },
  "power_status": "Unknown",
  "socket_path": "/tmp/boot-0.socket"
}

@ysksuzuki ysksuzuki self-assigned this Apr 1, 2021
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
@ysksuzuki ysksuzuki marked this pull request as ready for review April 1, 2021 04:36
Signed-off-by: Yusuke Suzuki <yusuke-suzuki@cybozu.co.jp>
@ysksuzuki ysksuzuki requested a review from masa213f April 1, 2021 04:47
Copy link
Contributor

@masa213f masa213f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@masa213f masa213f merged commit e85944c into main Apr 2, 2021
@masa213f masa213f deleted the fix-node-list-error branch April 2, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants