Skip to content

[*] remove metrics definitions from Postgres sink #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2025
Merged

[*] remove metrics definitions from Postgres sink #773

merged 1 commit into from
May 31, 2025

Conversation

pashagolub
Copy link
Collaborator

No description provided.

@pashagolub pashagolub self-assigned this May 31, 2025
@pashagolub pashagolub added refactoring Something done as it should've been done from the start sinks Where and how to store monitored data labels May 31, 2025
@pashagolub pashagolub force-pushed the remove-metrics-from-pg-sink branch from 1d32055 to 34e1864 Compare May 31, 2025 06:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 15361196387

Details

  • 10 of 13 (76.92%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 59.361%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/cmdopts/cmdoptions.go 0 1 0.0%
internal/sinks/postgres.go 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
internal/cmdopts/cmdoptions.go 1 66.96%
Totals Coverage Status
Change from base Build 15349072239: 0.1%
Covered Lines: 2603
Relevant Lines: 4385
💛 - Coveralls

@pashagolub pashagolub merged commit 488977d into master May 31, 2025
9 checks passed
@pashagolub pashagolub deleted the remove-metrics-from-pg-sink branch May 31, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pashagolub pashagolub

Labels
refactoring Something done as it should've been done from the start sinks Where and how to store monitored data
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pashagolub @coveralls