Skip to content

[*] drop support for discontinued Azure Single Server #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2025

Conversation

pashagolub
Copy link
Collaborator

No description provided.

@pashagolub pashagolub self-assigned this Apr 24, 2025
@pashagolub pashagolub added refactoring Something done as it should've been done from the start metrics Metrics related issues sources What sources and in what way to monitor labels Apr 24, 2025
@pashagolub pashagolub requested a review from Copilot April 24, 2025 14:26
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes support for the discontinued Azure Single Server by eliminating obsolete database size metrics and related caching logic while renaming fields for clarity.

  • Rename ApproxDBSizeB to ApproxDbSize in the connection settings
  • Remove deprecated metrics (db_size and table_stats) and associated DB size caching functions
  • Update logic for calculating database size using the new ApproxDbSize field

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
internal/sources/conn.go Renaming of the database size field for simplicity and consistency
internal/reaper/recommendations.go Removal of obsolete metric constants related to Azure Single Server
internal/reaper/reaper.go Calculation of DB size now leverages the renamed field and removes swapped metrics
internal/reaper/database.go Removal of the DBGetSizeMB function and its caching logic
internal/reaper/cache.go Removal of DB size caching variables
Comments suppressed due to low confidence (1)

internal/sources/conn.go:40

  • [nitpick] The field name 'ApproxDbSize' uses inconsistent acronym capitalization compared to typical Go conventions; consider renaming it to 'ApproxDBSize' for consistency.
ApproxDbSize     int64

@pashagolub pashagolub merged commit a88094f into master Apr 24, 2025
9 checks passed
@pashagolub pashagolub deleted the drop-azure-single branch April 24, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics related issues refactoring Something done as it should've been done from the start sources What sources and in what way to monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant