[*] migrate maintenance task logic to PL/pgSQL #1025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xgouda
added
enhancement
- move individual metric update logic to `admin.update_listing_table()`. - move dropped tables removal logic to `admin.remove_dropped_tables_listing()`. - use these new functions in the maintenance routine.
- the `MaintainUniqueSources` test calls `pgw.MaintainUniqueSources()` 3 times which sleeps a minute each time.
pashagolub
force-pushed
the
make-maintenance-in-plpgsql
branch
from
5c6510c to
c245c16
Compare
Pull Request Test Coverage Report for Build 19437140385Details
💛 - Coveralls |
pashagolub
reviewed
Nov 24, 2025
| if err := pgw.sinkDb.QueryRow(pgw.ctx, sqlGetAdvisoryLock).Scan(&lock); err != nil { | ||
| logger.Error("Getting admin.all_distinct_dbname_metrics maintainer advisory lock failed:", err) | ||
| logger.Infof("Trying to get maintenance advisory lock...") // to only have one "maintainer" in case of a "push" setup, as can get costly | ||
| if err := pgw.sinkDb.QueryRow(pgw.ctx, "SELECT admin.try_get_maintenance_lock();").Scan(&lock); err != nil { |
Collaborator
There was a problem hiding this comment.
I'm not sure it's a great improvement! :-D
Collaborator
Author
There was a problem hiding this comment.
It's not, but I think of it in terms of abstracting the maintenance logic from the Go code.
Collaborator
There was a problem hiding this comment.
Got it. I will get back to this later. I want to experiment locally. Need to produce some loads first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
admin.try_get_maintenance_lock().admin.update_listing_table(metric_table_name text).admin.remove_dropped_tables_listing(existing_metrics text[]).