Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Python2.7 Test Suite #1684

Merged
merged 5 commits into from
May 20, 2020
Merged

Fix Python2.7 Test Suite #1684

merged 5 commits into from
May 20, 2020

Conversation

DavidMansolino
Copy link
Member

Description
Some of the files recently committed are not python2.7 compatible

@DavidMansolino DavidMansolino self-assigned this May 20, 2020
@DavidMansolino DavidMansolino added the bug Something isn't working label May 20, 2020
@DavidMansolino DavidMansolino added this to the R2020a.rev2 milestone May 20, 2020
@DavidMansolino DavidMansolino marked this pull request as ready for review May 20, 2020 07:01
@DavidMansolino
Copy link
Member Author

✔️: travis_sources

@DavidMansolino DavidMansolino requested a review from a team May 20, 2020 07:02
@DavidMansolino DavidMansolino changed the title Fix Test Suite Fix Python2.7 Test Suite May 20, 2020
omichel
omichel approved these changes May 20, 2020
View reviewed changes
Copy link
Member

@omichel omichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully one day we will drop python 2.7 for good.

@DavidMansolino DavidMansolino merged commit 326ccda into master May 20, 2020
@DavidMansolino DavidMansolino deleted the fix-test-suite branch May 20, 2020 07:31
@DavidMansolino DavidMansolino modified the milestones: R2020a.rev2, R2020b Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omichel omichel omichel approved these changes

Assignees

@DavidMansolino DavidMansolino

Labels
bug Something isn't working
Milestone
R2020b
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidMansolino @omichel