Skip to content

Unexpected parameters cause web proto to break #5992

Open
@ad-daniel

Description

Describe the Bug

No sanity checks are performed on the PROTO when displaying them on the Web, the assumption is made that they are valid.
However when the user plays with the parameters, it's possible to set values that end up breaking the visualizer entirely (negative distances, remove nodes that are expected to be there, etc).
Once broken this way, due to the error, the visualizer effectively becomes unresponsive and a page refresh is needed to restore it.
Possible fixes are:

  • improve the proto themselves so that they perform sanity checks on the parameters (and use default value if unacceptable)
  • catch the eval error so at least it doesn't break the visualizer (fixes some but not all issues)

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions