Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveshare v4 icon rendering issues #14

Closed
cyberartemio opened this issue Jan 31, 2024 · 4 comments · Fixed by #17
Closed

Waveshare v4 icon rendering issues #14

cyberartemio opened this issue Jan 31, 2024 · 4 comments · Fixed by #17
Assignees
@cyberartemio
Labels
bug Something isn't working

Comments

@cyberartemio
Copy link
Owner

cyberartemio commented Jan 31, 2024 •
edited
Loading

Apparently, on Waveshare v3/v4 screens (and probably other screens) the icon is not rendering properly resulting in only 2 dots rendered on screen (both on display and also on the web ui).

EDIT: on v3 screens the icon renders fine. Tried to run with inverted colors also.

Bug reported by sn0ren

proof
@cyberartemio cyberartemio added bug Something isn't working help wanted Extra attention is needed labels Jan 31, 2024
@cyberartemio
Copy link
Owner Author

Seems like the plugin was installed using pwnagotchi plugins command and it doesn't download wof_assets directory. There are still some issues with the icon rendering on v4 displays but at least it's showing

@cyberartemio cyberartemio changed the title Waveshare v3/v4 icon rendering issues Waveshare v4 icon rendering issues Feb 20, 2024
@cyberartemio
Copy link
Owner Author

The icon still doesn't render right. Should rewrite the Icon Widget class

@cyberartemio cyberartemio reopened this Apr 1, 2024
@cyberartemio cyberartemio self-assigned this Apr 1, 2024
@cyberartemio cyberartemio removed the help wanted Extra attention is needed label Apr 1, 2024
cyberartemio added a commit that referenced this issue Apr 3, 2024
@cyberartemio
[core] changed icon rendering logic (maybe fix #14)
cc5f62e
@RoiArthurB
Copy link

Same issue with "waveshare_3" after copy-pasting installation procedure from READMEs

image

cyberartemio added a commit that referenced this issue Apr 4, 2024
@cyberartemio
[core] fixed icon issues (tested on waveshare v2 and v3 with evilsock…
fe6a721 
…et and jayofelony images)

Close #14
@cyberartemio
Copy link
Owner Author

I'm releasing v1.3. Try to update it and let me know if you still have the problem. Make sure to redownload the wof_assets directory.

Same issue with "waveshare_3" after copy-pasting installation procedure from READMEs

image

@cyberartemio cyberartemio linked a pull request Apr 4, 2024 that will close this issue
Fixed icon rendering issues #17
Merged
cyberartemio added a commit that referenced this issue Apr 4, 2024
@cyberartemio
[core] changed icon rendering logic (maybe fix #14)
d5f18c0
cyberartemio added a commit that referenced this issue Apr 4, 2024
@cyberartemio
[core] fixed icon issues (tested on waveshare v2 and v3 with evilsock…
92a912d 
…et and jayofelony images)

Close #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cyberartemio cyberartemio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed icon rendering issues cyberartemio/wof-pwnagotchi-plugin
2 participants
@RoiArthurB @cyberartemio