Add ocp 4.8.2 cli support for ci against ocp 4.8 #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codihuston
force-pushed
the
fix/ocp-next
branch
from
e1bd621 to
8f68ef3
Compare
codihuston
changed the title
codihuston
force-pushed
the
fix/ocp-next
branch
8 times, most recently
from
f679c6f to
ac91bfe
Compare
imheresamir
reviewed
Sep 9, 2021
codihuston
force-pushed
the
fix/ocp-next
branch
from
ac91bfe to
bd4ca0c
Compare
|
This PR stemmed from this JIRA task: ONYX-11430. Essentially, Infra wanted a test file that would test a set of projects against the OCP NEXT cluster. |
codihuston
force-pushed
the
fix/ocp-next
branch
from
bd4ca0c to
e7c91b4
Compare
- Add ocp 4.8.2 cli - Prefix secretless image with docker.io so that docker hub images can be pulled in ocp. This will resolve image pull issues with conjur-authn-k8s-client > IMPORTANT: the docker.io prefix is significant and impacts the conjur-authn-k8s-client when testing against ocp next (this will resolve the image pull error there as well)
codihuston
force-pushed
the
fix/ocp-next
branch
from
e7c91b4 to
efcc326
Compare
|
Code Climate has analyzed commit efcc326 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 87.5% (0.0% change). View more on Code Climate. |
imheresamir
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What's changed? Why were these changes made?
Added cli support for testing against OCP 4.8 by implementing v4.8.2 for the cli. Using older 3.* cli threw exceptions
when describing k8s resources in openshift.
How should the reviewer approach this PR, especially if manual tests are required?
Are there relevant screenshots you can add to the PR description?
N/A
What ticket does this PR close?
Resolves ONYX-11430
Checklists
Change log
Test coverage
This PR includes new unit and integration tests to go with the code changes, or
The test against the OCP 4.8 (next) cluster is not new, per se, but has not been passing until these changes.
The changes in this PR do not require tests
Documentation
READMEs) were updated in this PR, and/or there is a follow-on issue to update docs, or