Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Jenkins pipeline to use parseChangelog utility #181

Merged
merged 1 commit into from
May 11, 2023
Merged

Updated Jenkins pipeline to use parseChangelog utility #181

merged 1 commit into from
May 11, 2023

Conversation

juniortaeza
Copy link
Contributor

Desired Outcome

  • updates Jenkins pipeline to utilize parseChangelog tool

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: [insert issue ID]
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

@juniortaeza juniortaeza requested a review from a team as a code owner May 10, 2023 18:06
@szh
Copy link
Contributor

szh commented May 10, 2023

Nice, looks like it's finding an issue in the changelog now

gl-johnson
gl-johnson suggested changes May 10, 2023
View reviewed changes
Copy link
Contributor

@gl-johnson gl-johnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you squash this down to 1-2 commits since its a small change? After that happy to approve

@juniortaeza juniortaeza force-pushed the upgrade-pipeline-branch branch from a542129 to 9f1d51a Compare May 10, 2023 19:47
szh
szh approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@szh szh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juniortaeza juniortaeza merged commit 9bcaff4 into main May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szh szh szh approved these changes

@gl-johnson gl-johnson gl-johnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juniortaeza @szh @gl-johnson