Do not add unique id to service name #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In conjur-oss-helm-chart the release name defaults to conjur-oss and with that is the service name. Now in conjur-authn-k8s-client the release name has a unique id that is passed into conjur-oss-helm-chart. This change will keep the service name to conjur-oss regardless of the release name, which is how conjur-oss-helm-chart was running previously as
it does not use the unique id.
Desired Outcome
oc get service
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
conjur-oss NodePort 172.30.161.87 443:32333/TCP 43h
Implemented Changes
The service name will default to the fullnameOverride
Connected Issue/Story
Works towards App deployment on Openshift
Definition of Done
At least 1 todo must be completed in the sections below for the PR to be
merged.
Changelog
CHANGELOG update
Test coverage
changes, or
Documentation
README
s) were updated in this PRBehavior
Security