Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add unique id to service name #163

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

rpothier
Copy link
Contributor

@rpothier rpothier commented Aug 11, 2021

In conjur-oss-helm-chart the release name defaults to conjur-oss and with that is the service name. Now in conjur-authn-k8s-client the release name has a unique id that is passed into conjur-oss-helm-chart. This change will keep the service name to conjur-oss regardless of the release name, which is how conjur-oss-helm-chart was running previously as
it does not use the unique id.

Desired Outcome

oc get service
NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
conjur-oss NodePort 172.30.161.87 443:32333/TCP 43h

Implemented Changes

The service name will default to the fullnameOverride

Connected Issue/Story

Works towards App deployment on Openshift

Definition of Done

At least 1 todo must be completed in the sections below for the PR to be
merged.

Changelog

  • The CHANGELOG has been updated, or
  • This PR does not include user-facing changes and doesn't require a
    CHANGELOG update

Test coverage

  • This PR includes new unit and integration tests to go with the code
    changes, or
  • The changes in this PR do not require tests

Documentation

  • Docs (e.g. READMEs) were updated in this PR
  • A follow-up issue to update official docs has been filed here: insert issue ID
  • This PR does not require updating any documentation

Behavior

  • This PR changes product behavior and has been reviewed by a PO, or
  • These changes are part of a larger initiative that will be reviewed later, or
  • No behavior was changed with this PR

Security

  • Security architect has reviewed the changes in this PR,
  • These changes are part of a larger initiative with a separate security review, or
  • There are no security aspects to these changes

…with

that is the service name. Now in conjur-authn-k8s-client the release name
has a unique id that is passed into conjur-oss-helm-chart. This change will
keep the service name to conjur-oss reguardless of the release name.
Copy link
Contributor

@diverdane diverdane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@rpothier rpothier merged commit f3827dd into main Aug 12, 2021
@rpothier rpothier deleted the update-release-name-for-openshift branch August 12, 2021 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants